[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] XSM SILO boot time spew
- To: "Xin Li (Talons)" <xin.li@xxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
- Date: Wed, 7 Nov 2018 12:52:40 -0500
- Cc: Xen-devel List <xen-devel@xxxxxxxxxxxxx>
- Delivery-date: Wed, 07 Nov 2018 17:53:08 +0000
- Ironport-phdr: 9a23:RPRCsBKb1ClhXD8ktdmcpTZWNBhigK39O0sv0rFitYgfLfvxwZ3uMQTl6Ol3ixeRBMOHs60C07KempujcFRI2YyGvnEGfc4EfD4+ouJSoTYdBtWYA1bwNv/gYn9yNs1DUFh44yPzahANS47xaFLIv3K98yMZFAnhOgppPOT1HZPZg9iq2+yo9JDffwdFiCChbb9uMR67sRjfus4KjIV4N60/0AHJonxGe+RXwWNnO1eelAvi68mz4ZBu7T1et+ou+MBcX6r6eb84TaFDAzQ9L281/szrugLdQgaJ+3ART38ZkhtMAwjC8RH6QpL8uTb0u+ZhxCWXO9D9QKsqUjq+8ahkVB7oiD8GNzEn9mHXltdwh79frB64uhBz35LYbISTOfVwZKPdec4RS3RHUMhfSidNBpqwY5UTA+YEO+tTsovzqEYUrRamGAeiGu3vxD9LiHH406I13OYuHh3J0gE7A9IDsm7ZoMnpOKocU+24yrTDwzXZb/NR3Dfw8IbGfQonofGNQ71wddfax0cxGAjYj1uQs5bqMCmb1u8QtGWU8uVgWv+xhG4osQF+uCOixtssi4bVhoIVzUrI9SNiwIkvP9G4R0l7YcC9HZZWqiqUNJN2T9s/T2xntys20L0LtYOhcCQUx5kr2QTTZ+GBfoOV+BzsTvyRLi19hH99fbK/gAu9/la4x+3nU8m0zE5Kri1YktnQrnwN1wLc6syASvZl4keuwyyP1wHO6uFfO0w0iaraJIIhwr43jJYTt1jMHjTql0nsia+Wd0Ek9vCp6+ThfLrmuoeRO5J7hwzxKKgjmtGzDf4mPgUBQWSX4/mw2KXm/ULjQbVKivM2krPesJDfPckUu6G5DBJL3YYs8RawFSyr0MgYnHYbLFJFfwiLj47yO17UOvz4AvC/g0q0nDdx2//GJqHhAonKLnXbn7bhfLB951RYyAoy1t1Q+5NUCq0bIPLyVU79rsDXDhg8Mwas2eboFM191p8CWWKIGqKULKXSvkKS5u0xLeiAfpEYuDH6K/g9+fHul3E0lEQBcqmowZsXcnG4H/t8L0qFZnrsh88LEX0WsQomUOzqlFqCXCZcZnmsWaIw/yw0B5y4DYjdQoCgm7iB3CagHp1KfWBKEF+NHmnud4meXPcMci2ScYddlWlOZbmnA6sgnVGSvQv9zaEmZKKA6iwe85bi/NN0+/fShVc58jkiS4y01W2XQn48tWQPXzIslPRWp0Bnx0jF+q9/m/FCTvRY5u9TUxd8PpnZmb9UEdf3Dy7IeNaETB6KT52JGzg4QJplz9ACbklnEv2+nxvD2GysGLZTmLuVUs9nupnA1mT8cp4ug03N07Ms2hx/GJNC
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/31/2018 11:19 PM, Xin Li (Talons) wrote:
In patchset v4, we call register_xsm() to setup silo module.
This debug log is to check if some ops not overrided by the module.
I thought this is OK, since the log level is debug.
I think calling register_xsm() is good,
if we do want to suppress this debug log explicitly,
we can check if ops eqauls silo_xsm_ops in macro set_to_dummy_if_null().
The follow diff shows what I am suggesting, is it OK?
If SILO is a good example of what a potential third XSM module would look
like, it's probably better to just remove the printing and allow the
dummy module's hooks to fill in any null values in the xsm_operations
structure. The printing part was written with FLASK and ACM in mind,
which both intended to hook everything and might add new hooks without
changing the other.
Another possible solution would be to add a bool parameter to register_xsm
that disables the warnings instead of checking the pointer value, but that
feels like overkill to me; we still only have two XSM modules.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
