Xen project Mailing List

Re: [Xen-devel] [PATCH v4 05/19] xen: add some dummy headers for PVH mode

To: Daniel Kiper <daniel.kiper@xxxxxxxxxx>

From: Juergen Gross <jgross@xxxxxxxx>

Date: Thu, 8 Nov 2018 16:40:19 +0100

Autocrypt: addr=jgross@xxxxxxxx; prefer-encrypt=mutual; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNHkp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmRlPsLAeQQTAQIAIwUCU4xw6wIbAwcL CQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJELDendYovxMvi4UH/Ri+OXlObzqMANruTd4N zmVBAZgx1VW6jLc8JZjQuJPSsd/a+bNr3BZeLV6lu4Pf1Yl2Log129EX1KWYiFFvPbIiq5M5 kOXTO8Eas4CaScCvAZ9jCMQCgK3pFqYgirwTgfwnPtxFxO/F3ZcS8jovza5khkSKL9JGq8Nk czDTruQ/oy0WUHdUr9uwEfiD9yPFOGqp4S6cISuzBMvaAiC5YGdUGXuPZKXLpnGSjkZswUzY d9BVSitRL5ldsQCg6GhDoEAeIhUC4SQnT9SOWkoDOSFRXZ+7+WIBGLiWMd+yKDdRG5RyP/8f 3tgGiB6cyuYfPDRGsELGjUaTUq3H2xZgIPfOwE0EU4xwFgEIAMsx+gDjgzAY4H1hPVXgoLK8 B93sTQFN9oC6tsb46VpxyLPfJ3T1A6Z6MVkLoCejKTJ3K9MUsBZhxIJ0hIyvzwI6aYJsnOew cCiCN7FeKJ/oA1RSUemPGUcIJwQuZlTOiY0OcQ5PFkV5YxMUX1F/aTYXROXgTmSaw0aC1Jpo w7Ss1mg4SIP/tR88/d1+HwkJDVW1RSxC1PWzGizwRv8eauImGdpNnseneO2BNWRXTJumAWDD pYxpGSsGHXuZXTPZqOOZpsHtInFyi5KRHSFyk2Xigzvh3b9WqhbgHHHE4PUVw0I5sIQt8hJq 5nH5dPqz4ITtCL9zjiJsExHuHKN3NZsAEQEAAcLAXwQYAQIACQUCU4xwFgIbDAAKCRCw3p3W KL8TL0P4B/9YWver5uD/y/m0KScK2f3Z3mXJhME23vGBbMNlfwbr+meDMrJZ950CuWWnQ+d+ Ahe0w1X7e3wuLVODzjcReQ/v7b4JD3wwHxe+88tgB9byc0NXzlPJWBaWV01yB2/uefVKryAf AHYEd0gCRhx7eESgNBe3+YqWAQawunMlycsqKa09dBDL1PFRosF708ic9346GLHRc6Vj5SRA UTHnQqLetIOXZm3a2eQ1gpQK9MmruO86Vo93p39bS1mqnLLspVrL4rhoyhsOyh0Hd28QCzpJ wKeHTd0MAWAirmewHXWPco8p1Wg+V+5xfZzuQY0f4tQxvOpXpt4gQ1817GQ5/Ed/wsDtBBgB CAAgFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAlrd8NACGwIAgQkQsN6d1ii/Ey92IAQZFggA HRYhBFMtsHpB9jjzHji4HoBcYbtP2GO+BQJa3fDQAAoJEIBcYbtP2GO+TYsA/30H/0V6cr/W V+J/FCayg6uNtm3MJLo4rE+o4sdpjjsGAQCooqffpgA+luTT13YZNV62hAnCLKXH9n3+ZAgJ RtAyDWk1B/0SMDVs1wxufMkKC3Q/1D3BYIvBlrTVKdBYXPxngcRoqV2J77lscEvkLNUGsu/z W2pf7+P3mWWlrPMJdlbax00vevyBeqtqNKjHstHatgMZ2W0CFC4hJ3YEetuRBURYPiGzuJXU pAd7a7BdsqWC4o+GTm5tnGrCyD+4gfDSpkOT53S/GNO07YkPkm/8J4OBoFfgSaCnQ1izwgJQ jIpcG2fPCI2/hxf2oqXPYbKr1v4Z1wthmoyUgGN0LPTIm+B5vdY82wI5qe9uN6UOGyTH2B3p hRQUWqCwu2sqkI3LLbTdrnyDZaixT2T0f4tyF5Lfs+Ha8xVMhIyzNb1byDI5FKCb

Cc: hans@xxxxxxxxxxx, grub-devel@xxxxxxx, phcoder@xxxxxxxxx, xen-devel@xxxxxxxxxxxxx

Delivery-date: Thu, 08 Nov 2018 15:40:25 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Openpgp: preference=signencrypt

On 08/11/2018 16:36, Daniel Kiper wrote: > On Wed, Nov 07, 2018 at 03:49:51PM +0100, Juergen Gross wrote: >> On 07/11/2018 13:21, Daniel Kiper wrote: >>> On Fri, Nov 02, 2018 at 01:37:24PM +0100, Juergen Gross wrote: >>>> With Xen PVH mode adding a new machine type the machine related headers >>>> need to be present for the build to succeed. Most of the headers just >>>> need to include the related common i386 headers. Add those to the tree. >>>> >>>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx> >>>> --- >>>> V3: updated commit message (Daniel Kiper) >>>> xenpvh->xen_pvh (Daniel Kiper) >>>> --- >>>> include/grub/i386/xen_pvh/boot.h | 1 + >>>> include/grub/i386/xen_pvh/console.h | 1 + >>>> include/grub/i386/xen_pvh/int.h | 1 + >>>> include/grub/i386/xen_pvh/memory.h | 1 + >>>> include/grub/i386/xen_pvh/time.h | 1 + >>>> 5 files changed, 5 insertions(+) >>>> create mode 100644 include/grub/i386/xen_pvh/boot.h >>>> create mode 100644 include/grub/i386/xen_pvh/console.h >>>> create mode 100644 include/grub/i386/xen_pvh/int.h >>>> create mode 100644 include/grub/i386/xen_pvh/memory.h >>>> create mode 100644 include/grub/i386/xen_pvh/time.h >>>> >>>> diff --git a/include/grub/i386/xen_pvh/boot.h >>>> b/include/grub/i386/xen_pvh/boot.h >>>> new file mode 100644 >>>> index 000000000..6cd23aa83 >>>> --- /dev/null >>>> +++ b/include/grub/i386/xen_pvh/boot.h >>>> @@ -0,0 +1 @@ >>>> +#include <grub/i386/pc/boot.h> >>>> diff --git a/include/grub/i386/xen_pvh/console.h >>>> b/include/grub/i386/xen_pvh/console.h >>>> new file mode 100644 >>>> index 000000000..305a46d8e >>>> --- /dev/null >>>> +++ b/include/grub/i386/xen_pvh/console.h >>>> @@ -0,0 +1 @@ >>>> +#include <grub/i386/pc/console.h> >>>> diff --git a/include/grub/i386/xen_pvh/int.h >>>> b/include/grub/i386/xen_pvh/int.h >>>> new file mode 100644 >>>> index 000000000..0f1f9ee62 >>>> --- /dev/null >>>> +++ b/include/grub/i386/xen_pvh/int.h >>>> @@ -0,0 +1 @@ >>>> +#include <grub/i386/pc/int_types.h> >>> >>> I think that this begs for explanation in the commit message >>> why not grub/i386/pc/int.h. >> >> Okay. >> >>> >>>> diff --git a/include/grub/i386/xen_pvh/memory.h >>>> b/include/grub/i386/xen_pvh/memory.h >>>> new file mode 100644 >>>> index 000000000..8dd6f7c8c >>>> --- /dev/null >>>> +++ b/include/grub/i386/xen_pvh/memory.h >>>> @@ -0,0 +1 @@ >>>> +#include <grub/i386/coreboot/memory.h> >>> >>> Hmmm... Why not include/grub/i386/pc/memory.h? >> >> The coreboot variant is containing the stubs grub_machine_mmap_register >> and grub_machine_mmap_unregister I need, with the pc variant I'd have to >> add those to xen-pvh code. >> >> Using the coreboot variant for that purpose seems to be common practice: >> include/grub/i386/qemu/memory.h >> include/grub/i386/ieee1275/memory.h >> include/grub/i386/multiboot/memory.h >> are doing exactly the same. > > I am OK with it then. However, please say about that in the commit > message. Otherwise it looks like a mistake. Will do. Juergen _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.