[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/8] xen/page_alloc: Move get_pg_owner()/put_pg_owner() from x86 to common code



Hi Jan,

On 07/11/2018 09:28, Jan Beulich wrote:
On 06.11.18 at 20:14, <julien.grall@xxxxxxx> wrote:
From: Benjamin Sanda <ben.sanda@xxxxxxxxxxxxxxx>

get_pg_owner() and put_pg_owner() will be necessary in a follow-up
commit to support xentrace on Arm. So move the helper to common code.

Note that put_pg_owner() has been turned to a macro rather than static
inline because of inter-dependency between includes.

Could this be avoided by placing both in a different header,
e.g. sched.h?
This seems to work. I will use that in the next version.

Mid-term we should probably try to split out
type (structure) declarations from sched.h, to make it easier
to have full types available without having to respect other
include dependencies.

The include dependencies on Xen is a bit of a nightmare. I have started to clean it up on Arm and I will support any changes in the common headers.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.