[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v4 11/19] xen: get memory map from hypervisor for PVH
On Fri, Nov 02, 2018 at 01:37:30PM +0100, Juergen Gross wrote: > Retrieve the memory map from the hypervisor and normalize it to contain > no overlapping entries and to be sorted by address. > > Signed-off-by: Juergen Gross <jgross@xxxxxxxx> One nit pick below. Otherwise Reviewed-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx> > --- > V3: use grub_e820_mmap_entry instead of own struct (Daniel Kiper) > --- > grub-core/kern/i386/xen/pvh.c | 96 > ++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 95 insertions(+), 1 deletion(-) > > diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386/xen/pvh.c > index 7e90a4538..58e6fefd5 100644 > --- a/grub-core/kern/i386/xen/pvh.c > +++ b/grub-core/kern/i386/xen/pvh.c > @@ -23,9 +23,14 @@ > #include <grub/i386/cpuid.h> > #include <grub/i386/io.h> > #include <grub/xen.h> > +#include <grub/i386/linux.h> > #include <grub/machine/kernel.h> > +#include <grub/machine/memory.h> > +#include <xen/memory.h> > > -#define XEN_CONSOLE_PORT 0xe9 > +#define XEN_CONSOLE_PORT 0xe9 Probably this will disappear but if not please put properly aligned values in earlier patch to avoid such code shuffling. Daniel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |