Re: [Xen-devel] [PATCH 3/5] xen/domain: Audit config->max_vcpus during {, arch_}check_domain_config()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.11.18 at 19:44, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 08/10/18 14:45, Jan Beulich wrote:
>>
>>> --- a/xen/common/domain.c
>>> +++ b/xen/common/domain.c
>>> @@ -297,6 +297,9 @@ static int check_domain_config(struct 
> xen_domctl_createdomain *config)
>>>                             XEN_DOMCTL_CDF_xs_domain) )
>>>          return -EINVAL;
>>>  
>>> +    if ( config->max_vcpus < 1 )
>>> +        return -EINVAL;
>>> +
>>>      return arch_check_domain_config(config);
>>>  }
>> Any reason you don't remove the now redundant check from
>> domain_create(), which would allow ditching altogether x86's
>> domain_max_vcpus()?
> 
> That's done in the next patch, to simplify this one.

Yeah, I had noticed this once I got there. Half a sentence in the
description to explain the now possible cleanup is deferred
intentionally would have helped, but that's fine in any event.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel