[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 01/18] xen/arm: Move code that initializes VCPU context into a separate function

>>> On 12.11.18 at 12:30, <mirela.simonovic@xxxxxxxxxx> wrote:
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -73,6 +73,7 @@ int arch_domain_soft_reset(struct domain *d);
>  void arch_p2m_set_access_required(struct domain *d, bool access_required);
>  int arch_set_info_guest(struct vcpu *, vcpu_guest_context_u);
> +void _arch_set_info_guest(struct vcpu *, struct vcpu_guest_context *);

If the Arm maintainers are happy with such a name space violation
I won't object, but if you place this in a common header (without
strict need afaict) please respect the C spec reserving names like
this one for file scope symbols.

Also please don't post patches to xen-devel@ twice (using different
domain names).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.