[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

>>> On 12.11.18 at 12:50, <mirela.simonovic@xxxxxxxxxx> wrote:
> What?

Please don't top post.

> On Mon, Nov 12, 2018 at 12:42 PM Jan Beulich <JBeulich@xxxxxxxx> wrote:
>> >>> On 12.11.18 at 12:30, <mirela.simonovic@xxxxxxxxxx> wrote:
>> > --- a/xen/include/xen/sched.h
>> > +++ b/xen/include/xen/sched.h
>> > @@ -24,6 +24,7 @@
>> >  #include <xen/wait.h>
>> >  #include <public/xen.h>
>> >  #include <public/domctl.h>
>> > +#include <public/sched.h>
>> >  #include <public/sysctl.h>
>> >  #include <public/vcpu.h>
>> >  #include <public/vm_event.h>
>> Why?

I think given the context the question, even if terse, is pretty
clear: Why do you add this #include as the only change in this
header? Nothing in the header previously required it, and if
you have a sudden new requirement elsewhere, then please
include the extra header just there.

Also please accept that given the amount of time needed to
deal with incoming patches, it is not generally scalable to
always give long explanations to what seems pretty obvious
anyway. (I do realize that "obvious" is a rather subjective
attribute to things.)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.