Re: [Xen-devel] [PATCH v5 12/15] libxl: QEMU startup sync based on QMP

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Anthony PERARD writes ("Re: [PATCH v5 12/15] libxl: QEMU startup sync based on 
QMP"):
> On Tue, Oct 16, 2018 at 03:23:26PM +0100, Ian Jackson wrote:
> > It's rather odd that neither this patch, nor anything that follows,
> > does not stop libxl from also watching the xenstore path.  I think it
> > would be better to suppress that rather than leave vestigial
> > behaviour.  Can you add patch(es) to do that, right after this one ?
> 
> I can try. That also mean that we need to setup a new timeout that
> xswait is setting up right now.

Oh, good point.  That seems a bit tedious and fiddly.  Maybe it is
better to leave it until we can throw away the xswait entirely - since
that way there are, for now, fewer separate code paths in libxl.

> I don't really have an awnser on how to start timeout when we use
> libxl__ev_qmp. I guess just adding a call to libxl__ev_xswatch_register
> whenever we interact with libxl__ev_qmp is fine. I don't think we can do
> something similair to xswait.

I'm not sure I understand.  If you want to have a timeout that's not
part of an xswait, use libxl__ev_time.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel