[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 15/18] xen/arm: Resume memory management on Xen resume


On 13/11/2018 01:36, Stefano Stabellini wrote:
On Mon, 12 Nov 2018, Julien Grall wrote:
On 11/12/18 11:30 AM, Mirela Simonovic wrote:
We can turn this assembly code into a .macro, so that at least when we
get around to it, we just need to fix it one place. In fact, I noticed
that the code sequence right before "mmu_resumed" and the one right
after are both indentical to the ones head.S, it would be good to avoid
the duplication if possible.

This does not address my concern. We want to have suspend/resume compliant to the Arm architecture (at least to our best knowledge). Hiding it in a macro/function is not going to make it compliant.

Nobody wants its platform randomly crashing on suspend/resume because the Arm Arm was knowingly not followed. This is more critical than the boot one as we are going to call that more often. So what is the action plan to correctly resume memory management in this series?


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.