Re: [Xen-devel] [PATCH] libx86: Fix 32bit stubdom build of x86_cpuid_policy_fill_native()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.11.18 at 12:59, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/lib/x86/cpuid.c
> +++ b/xen/lib/x86/cpuid.c
> @@ -7,8 +7,8 @@ void x86_cpuid_policy_fill_native(struct cpuid_policy *p)
>      unsigned int i;
>  
>      cpuid_leaf(0, &p->basic.raw[0]);
> -    for ( i = 1; i < min(ARRAY_SIZE(p->basic.raw),
> -                         p->basic.max_leaf + 1ul); ++i )
> +    for ( i = 1; i < min_t(unsigned int, ARRAY_SIZE(p->basic.raw),
> +                           p->basic.max_leaf); ++i )

I dislike the (hidden) casting resulting from the uses of min_t() /
max_t(), so in a case like this I'd have preferred to replace 1ul
by sizeof(char) or some such. But I expect you wouldn't like this,
so either way
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel