[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 01/18] xen/arm: Move code that initializes VCPU context into a separate function

On Mon, Nov 12, 2018 at 2:15 PM Julien Grall <julien.grall@xxxxxxx> wrote:
> Hi Mirela,
> On 11/12/18 11:30 AM, Mirela Simonovic wrote:
> > From: Saeed Nowshadi <saeed.nowshadi@xxxxxxxxxx>
> >
> > The arch_set_info_guest() has code to initialize the context of a VCPU.
> > When a VCPU is resumed it needs to go through the same context
> > initialization excluding all the validations that this routine does.
> > We move the actual VCPU context setting into a function so that it can be
> > shared with the resume path.
> I would rather not introduce a function that skip validation. They are
> here to catch error when setting up vCPU registers. If those errors are
> not caught, then the hypervisor will likely crash on return to the guest.

Ok, then we should just use arch_set_info_guest.


> Cheers,
> --
> Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.