Re: [Xen-devel] [PATCH v7b 05/25] xen/arm: check for multiboot nodes only under /chosen

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 13/11/2018 17:51, Stefano Stabellini wrote:
> Make sure to only look for multiboot compatible nodes only under
> /chosen, not under any other paths (depth <= 3).
>
> Signed-off-by: Stefano Stabellini <stefanos@xxxxxxxxxx>
>
> ---
>
> Changes in v7:
> - set path size to 92, treat -FDT_ERR_NOSPACE as erro
>
> Changes in v6:
> - do not proceed if fdt_get_path returns error != -FDT_ERR_NOSPACE
> - remove sizeof, use hardcoded value
>
> Changes in v5:
> - add patch
> - add check on return value of fdt_get_path
> ---
>   xen/arch/arm/bootfdt.c | 14 +++++++++++---
>   1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index 44af11c..b94d8c7 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -173,7 +173,15 @@ static void __init process_multiboot_node(const void *fdt, 
> int node,
>       bootmodule_kind kind;
>       paddr_t start, size;
>       const char *cmdline;
> -    int len;
> +    /* sizeof("/chosen/") + DT_MAX_NAME + '/' + DT_MAX_NAME + '/0' => 92 */
> +    int len = 92;
len is a bit pointless. I will commit this patch with...

> +    char path[92];
> +    int ret;
> +
> +    /* Check that the node is under "/chosen" (first 7 chars of path) */
> +    ret = fdt_get_path(fdt, node, path, len);
... len replaced by sizeof(path) here.

With that:

Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel