Re: [Xen-devel] [PATCH 3/3] xen-init-dom0: set Dom0 UUID if requested

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Nov 14, 2018 at 03:16:49PM -0500, Jason Andryuk wrote:
[...]
> >  int main(int argc, char **argv)
> >  {
> >      int rc;
> > -    struct xs_handle *xsh;
> > +    struct xs_handle *xsh = NULL;
> > +    xc_interface *xch = NULL;
> >      char *domname_string = NULL, *domid_string = NULL;
> > +    libxl_uuid uuid;
> >
> >      xsh = xs_open(0);
> >      if (!xsh) {
> >          fprintf(stderr, "cannot open xenstore connection\n");
> > -        exit(1);
> > +        rc = 1;
> > +        goto out;
> > +    }
> > +
> > +    xch = xc_interface_open(NULL, NULL, 0);
> > +    if (!xch) {
> > +        fprintf(stderr, "xc_interface_open() failed\n");
> > +        rc = 1;
> 
> Do you want a goto out here?

Yes I do. Good catch!

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel