[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/8] xen/arm: Add support for read-only foreign mappings

> So I would prefer to stick with _t which is quite common within the p2m
> code base so far.

I've found a similar code only in one place - p2m_get_entry()
function. And it is, at least, somehow commented there:
    /* Allow t to be NULL */
    t = t ?: &_t;

    *t = p2m_invalid;

But IMO, it is really confusing to write a code to calculate and store
a value which clearly is not needed by a caller.
From another hand, I'm not sure if a compiler would be intelligent
enough to factor out the odd code from execution pass on the incoming
null pointer.

I'm sorry, but I can't pass my RB for `_t`.

Andrii Anisov.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.