Re: [Xen-devel] [PATCH v4 1/5] vpci: fix updating the command register

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.11.18 at 12:57, <roger.pau@xxxxxxxxxx> wrote:
> @@ -413,7 +412,7 @@ static void rom_write(const struct pci_dev *pdev, 
> unsigned int reg,
>          header->rom_enabled = new_enabled;
>          pci_conf_write32(pdev->seg, pdev->bus, slot, func, reg, val);
>      }
> -    else if ( modify_bars(pdev, new_enabled, true) )
> +    else if ( modify_bars(pdev, new_enabled ? PCI_COMMAND_MEMORY : 0, true) )

Do you really mean to clear all other defined bits of the command
register here?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel