[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [linux-3.18 bisection] complete test-amd64-i386-pair
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-pair testid xen-boot/dst_host Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Bug introduced: 7b8052e19304865477e03a0047062d977309a22f Bug not present: d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/130465/ commit 7b8052e19304865477e03a0047062d977309a22f Author: Jan Beulich <JBeulich@xxxxxxxx> Date: Mon Oct 19 04:23:29 2015 -0600 igb: fix NULL derefs due to skipped SR-IOV enabling [ Upstream commit be06998f96ecb93938ad2cce46c4289bf7cf45bc ] The combined effect of commits 6423fc3416 ("igb: do not re-init SR-IOV during probe") and ceee3450b3 ("igb: make sure SR-IOV init uses the right number of queues") causes VFs no longer getting set up, leading to NULL pointer dereferences due to the adapter's ->vf_data being NULL while ->vfs_allocated_count is non-zero. The first commit not only neglected the side effect of igb_sriov_reinit() that the second commit tried to account for, but also that of setting IGB_FLAG_HAS_MSIX, without which igb_enable_sriov() is effectively a no-op. Calling igb_{,re}set_interrupt_capability() as done here seems to address this, but I'm not sure whether this is better than sinply reverting the other two commits. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Tested-by: Aaron Brown <aaron.f.brown@xxxxxxxxx> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/linux-3.18/test-amd64-i386-pair.xen-boot--dst_host.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/linux-3.18/test-amd64-i386-pair.xen-boot--dst_host --summary-out=tmp/130471.bisection-summary --basis-template=128858 --blessings=real,real-bisect --flight=130471 linux-3.18 test-amd64-i386-pair xen-boot/dst_host Searching for failure / basis pass: 130367 fail [dst_host=debina1,src_host=debina0] / 128858 [dst_host=albana0,src_host=albana1] 128841 [dst_host=pinot1,src_host=pinot0] 128807 [dst_host=elbling0,src_host=elbling1] 128691 [dst_host=albana1,src_host=albana0] 128258 [dst_host=pinot0,src_host=pinot1] 128232 [dst_host=baroque1,src_host=baroque0] 128177 [dst_host=albana1,src_host=albana0] 128096 ok. Failure / basis pass flights: 130367 / 128096 (tree with no url: minios) (tree with no url: ovmf) (tree with no url: seabios) Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Latest 78e0897dd8b321ba1b4a2137778ab7ae7d400af5 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be Basis pass 921b2fed6a79439ef1609ef4af0ada5cccb3555c c530a75c1e6a472b0eb9558310b518f0dfcd8860 9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149 de5b678ca4dcdfa83e322491d478d66df56c1986 940185b2f6f343251c2b83bd96e599398cea51ec Generating revisions with ./adhoc-revtuple-generator git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git#921b2fed6a79439ef1609ef4af0ada5cccb3555c-78e0897dd8b321ba1b4a2137778ab7ae7d400af5 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen-traditional.git#9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149-d0d8ad39ecb51cd7497cd524484fe09f50876798 git://xenbits.xen.org/qemu-xen.git#de5b678ca4dcdfa83e322491d478d66df56c1986-de5b678ca4dcdfa83e322491d478d66df56c1986 git://xenbits.xen.org/xen.git#940185b2f6f343251c2b83bd96e599398cea51ec-2cf113891a38cc05434bc9876ffc107a990887be Loaded 3004 nodes in revision graph Searching for test results: 128096 pass 921b2fed6a79439ef1609ef4af0ada5cccb3555c c530a75c1e6a472b0eb9558310b518f0dfcd8860 9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149 de5b678ca4dcdfa83e322491d478d66df56c1986 940185b2f6f343251c2b83bd96e599398cea51ec 128177 [dst_host=albana1,src_host=albana0] 128232 [dst_host=baroque1,src_host=baroque0] 128258 [dst_host=pinot0,src_host=pinot1] 128691 [dst_host=albana1,src_host=albana0] 128807 [dst_host=elbling0,src_host=elbling1] 128858 [dst_host=albana0,src_host=albana1] 128841 [dst_host=pinot1,src_host=pinot0] 129760 fail 78e0897dd8b321ba1b4a2137778ab7ae7d400af5 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 129845 fail 78e0897dd8b321ba1b4a2137778ab7ae7d400af5 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130067 fail 78e0897dd8b321ba1b4a2137778ab7ae7d400af5 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130203 fail 78e0897dd8b321ba1b4a2137778ab7ae7d400af5 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130416 pass 0d63979c1bc9c85578be4c589768a13dc0a7c5eb c530a75c1e6a472b0eb9558310b518f0dfcd8860 9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149 de5b678ca4dcdfa83e322491d478d66df56c1986 c49894090c22473c5477e780a829b0931a90b4f9 130410 pass 921b2fed6a79439ef1609ef4af0ada5cccb3555c c530a75c1e6a472b0eb9558310b518f0dfcd8860 9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149 de5b678ca4dcdfa83e322491d478d66df56c1986 940185b2f6f343251c2b83bd96e599398cea51ec 130420 pass 3e8de24dea4c508bc04814d79a5459f111d41958 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130441 pass d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130423 pass 086753c47f2346a6f7fa9e6769d3b5b110603075 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130412 fail 78e0897dd8b321ba1b4a2137778ab7ae7d400af5 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130428 fail 0f1490a7573919a27dfc370c29a87caf142db993 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130426 pass ffad2775c340740482d0f5af3765121d8a5c1b69 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130433 fail e57bb9912c92b17cc4926a6e00c9505fb38b65d0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130437 fail 7b8052e19304865477e03a0047062d977309a22f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130436 pass 61fde28f92ab9a329ef06e0ab3f41269e3930213 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130444 fail 7b8052e19304865477e03a0047062d977309a22f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130367 fail 78e0897dd8b321ba1b4a2137778ab7ae7d400af5 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130451 pass d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130457 fail 7b8052e19304865477e03a0047062d977309a22f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130460 pass d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be 130465 fail 7b8052e19304865477e03a0047062d977309a22f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be Searching for interesting versions Result found: flight 128096 (pass), for basis pass Result found: flight 129760 (fail), for basis failure Repro found: flight 130410 (pass), for basis pass Repro found: flight 130412 (fail), for basis failure 0 revisions at d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 2cf113891a38cc05434bc9876ffc107a990887be No revisions left to test, checking graph state. Result found: flight 130441 (pass), for last pass Result found: flight 130444 (fail), for first failure Repro found: flight 130451 (pass), for last pass Repro found: flight 130457 (fail), for first failure Repro found: flight 130460 (pass), for last pass Repro found: flight 130465 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Bug introduced: 7b8052e19304865477e03a0047062d977309a22f Bug not present: d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/130465/ commit 7b8052e19304865477e03a0047062d977309a22f Author: Jan Beulich <JBeulich@xxxxxxxx> Date: Mon Oct 19 04:23:29 2015 -0600 igb: fix NULL derefs due to skipped SR-IOV enabling [ Upstream commit be06998f96ecb93938ad2cce46c4289bf7cf45bc ] The combined effect of commits 6423fc3416 ("igb: do not re-init SR-IOV during probe") and ceee3450b3 ("igb: make sure SR-IOV init uses the right number of queues") causes VFs no longer getting set up, leading to NULL pointer dereferences due to the adapter's ->vf_data being NULL while ->vfs_allocated_count is non-zero. The first commit not only neglected the side effect of igb_sriov_reinit() that the second commit tried to account for, but also that of setting IGB_FLAG_HAS_MSIX, without which igb_enable_sriov() is effectively a no-op. Calling igb_{,re}set_interrupt_capability() as done here seems to address this, but I'm not sure whether this is better than sinply reverting the other two commits. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Tested-by: Aaron Brown <aaron.f.brown@xxxxxxxxx> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> pnmtopng: 82 colors found Revision graph left in /home/logs/results/bisect/linux-3.18/test-amd64-i386-pair.xen-boot--dst_host.{dot,ps,png,html,svg}. No revision to test. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |