[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 1/9] mm: Introduce new vm_insert_range API
- To: Souptick Joarder <jrdr.linux@xxxxxxxxx>
- From: William Kucharski <william.kucharski@xxxxxxxxxx>
- Date: Wed, 21 Nov 2018 04:19:11 -0700
- Cc: Michal Hocko <mhocko@xxxxxxxx>, Heiko Stuebner <heiko@xxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Linux-MM <linux-mm@xxxxxxxxx>, linux1394-devel@xxxxxxxxxxxxxxxxxxxxx, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, oleksandr_andrushchenko@xxxxxxxx, joro@xxxxxxxxxx, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, rppt@xxxxxxxxxxxxx, airlied@xxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-rockchip@xxxxxxxxxxxxxxxxxxx, treding@xxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, Kees Cook <keescook@xxxxxxxxxxxx>, pawel@xxxxxxxxxx, Rik van Riel <riel@xxxxxxxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, rppt@xxxxxxxxxxxxxxxxxx, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, mchehab@xxxxxxxxxx, iamjoonsoo.kim@xxxxxxx, vbabka@xxxxxxx, Juergen Gross <jgross@xxxxxxxx>, hjc@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxx, Kyungmin Park <kyungmin.park@xxxxxxxxxxx>, stefanr@xxxxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, robin.murphy@xxxxxxx, "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>
- Delivery-date: Wed, 21 Nov 2018 11:33:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Could you add a line to the description explicitly stating that a failure
to insert any page in the range will fail the entire routine, something
like:
> * This allows drivers to insert range of kernel pages they've allocated
> * into a user vma. This is a generic function which drivers can use
> * rather than using their own way of mapping range of kernel pages into
> * user vma.
> *
> * A failure to insert any page in the range will fail the call as a whole.
It's obvious when reading the code, but it would be self-documenting to
state it outright.
Thanks!
-- Bill
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
