[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/4] x86/vvmx: Don't call vmsucceed() at the end of virtual_vmexit()

> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx]
> Sent: Thursday, November 15, 2018 11:31 PM
> On 15/11/2018 15:28, Sergey Dyasli wrote:
> > On 15/11/2018 13:52, Andrew Cooper wrote:
> >> This ends up corrupting L1's view of RFLAGS by setting ZF.  The correct
> value
> >> is established earlier in the function.
> > vmsucceed() doesn't set any flags, only clears some. And in this function
> it's
> > just redundant. ZF is set by VMfailValid. So I think the description must be
> > changed.
> Oh - so it does.  Yes - I was confusing it with the failvalid case.
> I'll fix the wording to "The correct RFLAGS value is established earlier
> in the function, and this call has no net effect."

with wording fixed, Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.