[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] remove the ->mapping_error method from dma_map_ops V2
- To: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Fri, 23 Nov 2018 07:55:11 +0100
- Cc: linux-arch@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, joro@xxxxxxxxxx, the arch/x86 maintainers <x86@xxxxxxxxxx>, linux@xxxxxxxxxxxxxxx, Linux List Kernel Mailing <linux-kernel@xxxxxxxxxxxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, jdmason@xxxxxxxx, robin.murphy@xxxxxxx, Christoph Hellwig <hch@xxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, m.szyprowski@xxxxxxxxxxx
- Delivery-date: Fri, 23 Nov 2018 06:55:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Nov 22, 2018 at 09:55:25AM -0800, Linus Torvalds wrote:
> No, the big immediate benefit of allowing "return -EINVAL" etc is
> simply legibility and error avoidance.
Well, I can tweak the last patch to return -EINVAL from dma_mapping_error
instead of the old 1 is as bool true. The callers should all be fine,
although I'd have to audit them. Still wouldn't help with being able to
return different errors.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
