[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] common: make sure symbols-dummy.o gets rebuilt when needed

>>> On 22.11.18 at 16:30, <wei.liu2@xxxxxxxxxx> wrote:
> On Thu, Nov 22, 2018 at 03:47:41AM -0700, Jan Beulich wrote:
>> --- a/xen/arch/arm/Makefile
>> +++ b/xen/arch/arm/Makefile
>> @@ -100,9 +100,6 @@ prelink.o: $(ALL_OBJS)
>>      $(LD) $(LDFLAGS) -r -o $@ $^
>>  endif
>> -$(BASEDIR)/common/symbols-dummy.o:
>> -    $(MAKE) -f $(BASEDIR)/Rules.mk -C $(BASEDIR)/common symbols-dummy.o
>> -
>>  $(TARGET)-syms: prelink.o xen.lds $(BASEDIR)/common/symbols-dummy.o

I've done this, but I've thought of another problem the chosen
approach causes (and meanwhile verified it indeed does): The
new dependency on the phony "extra" target causes a full re-link
during "make install-xen", resulting in various files that are
supposed to be ordinary-user-owned to become root-owned. I
think I want/need to invent some trickery similar to that in the
delete-unfresh-files rule.

Of course the question continues to be (I've raised this years
before already) why we do a full rebuild cycle in the first place
during the install phase. x86 Linux, for example, avoids this
(but Linux as a whole is inconsistent, as ISTR in the ia64 case
a full re-build gets triggered.

The other alternative I can see would require quite a bit more
surgery: We could stop keying sub-directory traversals off of
the respective built_in.o files, such that those don't need to
depend on this new phony target.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.