Re: [Xen-devel] [PATCH v5 1/6] vpci: fix updating the command register

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.11.18 at 17:01, <roger.pau@xxxxxxxxxx> wrote:
> When switching the memory decoding bit in the command register the
> rest of the changes where dropped, leading to only the memory decoding
> bit being updated.
> 
> Fix this by writing the command register once the guest physmap
> manipulations are done if there are changes to the memory decoding
> bit.
> 
> Note that when only mapping/unmapping the ROM BAR a fabricated command
> register value is passed to modify_bars which is only used to signal
> whether the action is a mapping or unmapping, but the value is never
> written to the device command register. Turn the maodify_decoding
> ASSERT into an ASSERT_UNREACHABLE and make sure that non-debug builds
> won't end up writing to the command register if only modifying the ROM
> BAR.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel