Re: [Xen-devel] [PATCH v2] amd-iommu: remove page merging code

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 27 November 2018 16:38
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: Brian Woods <brian.woods@xxxxxxx>; Suravee Suthikulpanit
> <suravee.suthikulpanit@xxxxxxx>; xen-devel <xen-
> devel@xxxxxxxxxxxxxxxxxxxx>
> Subject: RE: [Xen-devel] [PATCH v2] amd-iommu: remove page merging code
> 
> >>> On 27.11.18 at 17:05, <Paul.Durrant@xxxxxxxxxx> wrote:
> > Well, I could just leave PV-IOMMU unimplemented for AMD h/w if you think
> the
> > page merging code is more important since, without the spare ignored
> bits, I
> > have no way to track pages added by the hypercall vs. those added at
> start of
> > day. I personally think that the simpler code is worthwhile in itself
> but I
> > guess you disagree.
> 
> Not exactly: With a proper reason (here: you need to free up at least
> one of the bits; "for other potential use" simply is too vague for my
> taste, and to be honest I had already forgotten about this need of
> yours), I can live with this. Plus I'm not the maintainer of this code
> anyway.
> 

Ok, I'll send v3 adjusting the comment again.

  Paul

> Jan
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel