Re: [Xen-devel] [PATCH] xen: remove trailing spaces from public headers

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.11.18 at 13:57, <wei.liu2@xxxxxxxxxx> wrote:
> On Wed, Nov 28, 2018 at 05:52:57AM -0700, Jan Beulich wrote:
>> >>> On 28.11.18 at 13:32, <jgross@xxxxxxxx> wrote:
>> > Several public header files have trailing spaces in them. This is
>> > rather annoying when importing them into other projects as they might
>> > be rejected not complying to coding style.
>> > 
>> > Remove the trailing spaces in all headers below xen/include/public/.
>> > 
>> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>> > ---
>> > I have omitted tmem.h in order to avoid a conflict with Wei's tmem
>> > removal series.
>> 
>> To be honest I'm not convinced removing the public header would
>> be an appropriate step to take.
> 
> IIRC someone said tmem is never used, so what's the point of keeping
> tmem.h? Unless I'm misremembering?

Well, "never used" is a fuzzy term. It is a fact that code exists in
Linux (which is about to be removed as well). We don't know who
else is carrying code built against our public tmem.h, which is
different from that code perhaps also being dead. The original
idea (or the way I've been understanding it all the years) with
the public interface was that we'd never break people building
against them (and on the assumption that they may take our
headers verbatim, rather than - like e.g. Linux - cloning them;
otherwise installing the headers would be an entirely pointless
part of the build process), as long as they adhere to some
simple rules (like suitably defining __XEN_INTERFACE_VERSION__).

As a result
- tools only parts of the public interface may of course be
  deleted,
- general parts ought to remain, but may get framed by a
  __XEN_INTERFACE_VERSION__ conditional.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel