[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 6/9] libxl: Move qmp cleanup into devicemodel destroy function

To: George Dunlap <george.dunlap@xxxxxxxxxx>
From: Ian Jackson <ian.jackson@xxxxxxxxxx>
Date: Wed, 28 Nov 2018 16:39:57 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Wei Liu <wei.liu2@xxxxxxxxxx>
Delivery-date: Wed, 28 Nov 2018 16:40:07 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

George Dunlap writes ("[PATCH 6/9] libxl: Move qmp cleanup into devicemodel 
destroy function"):
> Removing the qmp connection is logically part of the device model
> destruction; having the caller destroy it is a mild layering
> violation.
> 
> Move libxl__qmp_cleanup() into libxl__destroy_device_model().  This
> will make it easier when we make devicemodel destruction asynchronous.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

References:
- [Xen-devel] [PATCH 1/9] libxl: Remove redundant pidpath setting
  - From: George Dunlap
- [Xen-devel] [PATCH 6/9] libxl: Move qmp cleanup into devicemodel destroy function
  - From: George Dunlap

Prev by Date: Re: [Xen-devel] [PATCH 5/9] libxl: Do root checks once in libxl__domain_get_device_model_uid
Next by Date: Re: [Xen-devel] [PATCH 14/18] xen: add implementations of xen-qdisk connect and disconnect functions...
Previous by thread: [Xen-devel] [PATCH 6/9] libxl: Move qmp cleanup into devicemodel destroy function
Next by thread: [Xen-devel] [PATCH 5/9] libxl: Do root checks once in libxl__domain_get_device_model_uid
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.