[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 7/9] libxl: Make killing of device model asynchronous

George Dunlap writes ("[PATCH 7/9] libxl: Make killing of device model 
> Or at least, give it an asynchronous interface so that we can make it
> actually asynchronous in subsequent patches.
> Create state structures and callback function signatures.  Add the
> state structure to libxl__destroy_domid_state.  Break
> libxl__destroy_domid down into two functions.
> +/* Used to detroy the device model */
> +_hidden void libxl__destroy_device_model(libxl__egc *egc,
> +                                         libxl__destroy_devicemodel_state 
> *ddms);

I think that comment is rather pointless (but I won't object if you
really want to keep it).  Conversely it would be nice to say somewhere
that ddms->callback may be called reentrantly.

Everything else LGTM.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.