Re: [Xen-devel] [PATCH 3/9] libxl: Get rid of support for QEMU_USER_BASE (xen-qemuuser-domidNN)

[George Dunlap <George.Dunlap@xxxxxxxxxx>]

> On Nov 28, 2018, at 4:34 PM, Ian Jackson <ian.jackson@xxxxxxxxxx> wrote:
> 
> George Dunlap writes ("[PATCH 3/9] libxl: Get rid of support for 
> QEMU_USER_BASE (xen-qemuuser-domidNN)"):
>> QEMU_USER_BASE allows a user to specify the UID to use when running
>> the devicemodel for a specific domain number.  Unfortunately, this is
>> not really practical: It requires nearly 32,000 entries in
>> /etc/passwd.  QEMU_USER_RANGE_BASE is much more practical.
> 
> Is the presence of this code causing a problem ?  I am happy to
> declare it unsupported.
> 
> I provided it because the behaviour of choosing a uid which has *no*
> passwd entry might reasonably be regarded as anomalous and
> undesirable.
> 
> I have used systems with O(32k) password file entries for real
> users…

With QEMU_USER_BASE, there are 5 qemu uid cases to consider (root, 
device_model_user, QEMU_USER_RANGE_BASE, QEMU_USER_BASE, and QEMU_USER_SHARED). 
 Having one less just simplifies the thinking and the logic.  Since I 
considered QEMU_USER_BASE to be impractical, I thought rather than spend time 
reasoning about it, I’d just delete it.

I’d personally just as soon leave it out (and add it back in if someone asks 
for it), but if you think it has value I can leave it in and do the work of 
thinking about the logic.

 -George
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel