Re: [Xen-devel] [PATCH V10 4/5] p2m: Always use hostp2m when clipping rangesets

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.11.18 at 22:56, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> Changes since V9:
>  - Removed the patch RFC (replaced by a printk(XENLOG_G_WARNING).
>  - Reused start and end in change_type_range() and removed the
>    intermediary variables range_start and range_end.
>  - Added an extra explanation for the if ( start > end ) return;
>    code in the comment.

This last item isn't really taking care of the comments I gave on v9.
The _incoming_ start being larger than the _incoming_ end is
something worth to point out. But you put that check after clipping
end. Furthermore it looks like you continue to break the case
where ->max_mapped_pfn increases subsequently, i.e. you still
don't update the rangeset with the unmodified incoming values.
Or otherwise I would have expected an explanation (as a reply
to my comments, not necessarily by adding to description or
comments of the patch here) why either this is not an issue or I'm
misreading anything.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel