[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] tools/libxc: Fix error handling in get_cpuid_domain_info()

>>> On 29.11.18 at 20:20, <andrew.cooper3@xxxxxxxxxx> wrote:
> get_cpuid_domain_info() has two conflicting return styles - either -error for
> local failures, or -1/errno for hypercall failures.  Switch to consistently
> use -error.
> While fixing the xc_get_cpu_featureset(), take the opportunity to remove the
> redundancy and move it to be adjacent to the other featureset handling.

Having noticed the redundancy before, I was assuming this was done
to prevent altering host_nr_features early, just in case future code
additions would want to use its original value. The way it is now, the
code folding looks correct.

> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.