Re: [Xen-devel] [Qemu-devel] [PATCH] xen/pt: Fix a xen passthrough failure

[no-reply@xxxxxxxxxxx]

Hi,

This series seems to have some coding style problems. See output below for
more information:



Message-id: 20181203023728.26774-1-yan.y.zhao@xxxxxxxxx
Type: series
Subject: [Qemu-devel] [PATCH] xen/pt: Fix a xen passthrough failure

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c561490 xen/pt: Fix a xen passthrough failure

=== OUTPUT BEGIN ===
Checking PATCH 1/1: xen/pt: Fix a xen passthrough failure...
ERROR: space required before the open parenthesis '('
#27: FILE: hw/xen/xen_pt.c:850:
+    if(machine_irq == 0) {

WARNING: line over 80 characters
#47: FILE: hw/xen/xen_pt_config_init.c:306:
+        XEN_PT_LOG(&s->dev, "machine irq is 0, init guest PCI_INTERRUPT_PIN to 
0\n");

total: 1 errors, 1 warnings, 24 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@xxxxxxxxxx
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel