[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 1/2] x86/svm: Improve diagnostics when __get_instruction_length_from_list() fails
>>> On 03.12.18 at 10:10, <Paul.Durrant@xxxxxxxxxx> wrote: >> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx] >> Sent: 30 November 2018 17:07 >> >> RFC: __get_instruction_length_from_list() tries to cope with VMEXIT_IOIO, >> but >> IN/OUT instructions aren't in the decode list and I can't spot an entry >> point >> from the IOIO path. Am I missing something? > > Yes, odd. IOIO are handled in the ifdef NDEBUG blocks but an IOIO exit does > indeed not call into __get_instruction_length() but does the same calculation > inline. Indeed commit 147808b8b8 introduced this without there being a visible or stated reason. Andre, any chance you can reconstruct the reason from almost 9 years ago? The __get_instruction_length() invocation the change added is VMX specific ... Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |