Re: [Xen-devel] [PATCH 2/2] x86/hvm: Corrections to RDTSCP intercept handling

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Andrew Cooper
> Sent: 03 December 2018 11:14
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>; Xen-devel <xen-
> devel@xxxxxxxxxxxxx>
> Cc: Jan Beulich <JBeulich@xxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>; Roger
> Pau Monne <roger.pau@xxxxxxxxxx>; Jun Nakajima <jun.nakajima@xxxxxxxxx>;
> Kevin Tian <kevin.tian@xxxxxxxxx>; Boris Ostrovsky
> <boris.ostrovsky@xxxxxxxxxx>; Suravee Suthikulpanit
> <suravee.suthikulpanit@xxxxxxx>; Brian Woods <brian.woods@xxxxxxx>;
> Juergen Gross <jgross@xxxxxxxx>
> Subject: Re: [PATCH 2/2] x86/hvm: Corrections to RDTSCP intercept handling
> 
> On 03/12/2018 09:17, Paul Durrant wrote:
> >> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> >> index 365eeb2..a9f9b9b 100644
> >> --- a/xen/arch/x86/hvm/vmx/vmx.c
> >> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> >> @@ -3589,6 +3589,7 @@ void vmx_vmexit_handler(struct cpu_user_regs
> *regs)
> >>      unsigned long exit_qualification, exit_reason, idtv_info,
> intr_info =
> >> 0;
> >>      unsigned int vector = 0, mode;
> >>      struct vcpu *v = current;
> >> +    struct domain *currd = v->domain;
> > ... following the usual rules, you should now convert all uses of v-
> >domain in this function to use currd.
> 
> If this were new development work then perhaps (although it would take a
> series to clean vmx_vmexit_handler() up to style).
> 
> In this case however, the patch needs backporting to all the stable
> trees, at which point minimum perturbance is the most important aspect.

Fair enough.

  Paul

> 
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel