Re: [Xen-devel] [PATCH 04/25] argo: define argo_dprintk for subsystem debugging

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.12.18 at 02:32, <christopher.w.clark@xxxxxxxxx> wrote:
> A convenience for working on development of the argo subsystem:
> toggling a local #define variable turns on just the debug messages
> in this subsystem.

I'm afraid I don't see the #define variable to toggle. I assume it's
ARGO_DEBUG, but there's no #define line for it anywhere here.

>   printk("argo: " format, ## args )

Was this line misplaced here? It doesn't look related to the rest of the
description.

> --- a/xen/common/argo.c
> +++ b/xen/common/argo.c
> @@ -19,6 +19,19 @@
>  #include <xen/errno.h>
>  #include <xen/guest_access.h>
>  
> +/*
> + * Debugs
> + */
> +
> +#ifdef ARGO_DEBUG
> +#define argo_dprintk(format, args...)            \
> +    do {                                         \
> +        printk("argo: " format, ## args );       \
> +    } while ( 1 == 0 )

What wrong with

#define argo_dprintk(format, args...) printk("argo: " format, ## args )

?

> +#else
> +#define argo_dprintk(format, ... ) (void)0

Please fully parenthesize macro expansions.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel