[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH RFCv2 1/4] mm/memory_hotplug: Introduce memory block types
- To: David Hildenbrand <david@xxxxxxxxxx>
- From: Wei Yang <richard.weiyang@xxxxxxxxx>
- Date: Mon, 3 Dec 2018 20:58:36 +0000
- Cc: Oscar Salvador <osalvador@xxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, Wei Yang <richard.weiyang@xxxxxxxxx>, linux-mm@xxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, linux-s390@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>, linux-acpi@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Michal Such??nek <msuchanek@xxxxxxx>, Pavel Tatashin <pavel.tatashin@xxxxxxxxxxxxx>, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, "mike.travis@xxxxxxx" <mike.travis@xxxxxxx>, Martin Schwidefsky <schwidefsky@xxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>, Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>, Andrew Banman <andrew.banman@xxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, devel@xxxxxxxxxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx
- Delivery-date: Mon, 03 Dec 2018 20:58:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
[...]
>>>
>>> + if (type == MEMORY_BLOCK_NONE)
>>> + return -EINVAL;
>>
>> No one will pass in this value. Can we omit this check for now?
>
>I could move it to patch nr 2 I guess, but as I introduce
>MEMORY_BLOCK_NONE here it made sense to keep it in here.
>
Yes, this make sense to me now.
>(and I think at least for now it makes sense to not squash patch 1 and
>2, to easier discuss the new user interface/concept introduced in this
>patch).
>
>Thanks!
>
>--
>
>Thanks,
>
>David / dhildenb
--
Wei Yang
Help you, Help me
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
