[Xen-devel] Make grub error "too few arguments" with xen

["Chen, Farrah" <farrah.chen@xxxxxxxxx>]

Hi all,

When I make grub, I met error " too few arguments to function 
'grub_create_loader_cmdline'" with xen.
I used git bisect and found the error occurred from commit: 
4d4a8c96e3593d76fe7b025665ccdecc70a53c1f.
Do you have any ideas? Thanks a lot!

commit 4d4a8c96e3593d76fe7b025665ccdecc70a53c1f
Author: Vladimir Serbinenko <phcoder@xxxxxxxxx>
Date:   Tue Feb 7 02:10:14 2017 +0100

    verifiers: Add possibility to verify kernel and modules command lines

    Signed-off-by: Vladimir Serbinenko <phcoder@xxxxxxxxx>
    Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
    Reviewed-by: Ross Philipson <ross.philipson@xxxxxxxxxx>

Make steps and Error log:

cd grub
./autogen.sh
./configure --target=amd64 --with-platform=xen --prefix=${PWD}/../pvgrub2
make
..
loader/i386/xen.c: In function 'grub_cmd_xen':
loader/i386/xen.c:650:10: error: too few arguments to function 
'grub_create_loader_cmdline'
          sizeof (xen_state.next_start.cmd_line) - 1);
          ^
In file included from loader/i386/xen.c:38:0:
../include/grub/lib/cmdline.h:29:12: note: declared here
grub_err_t grub_create_loader_cmdline (int argc, char *argv[], char *buf,
            ^
loader/i386/xen.c:651:3: error: pointer targets in passing argument 1 of 
'grub_verify_string' differ in signedness [-Werror=pointer-sign]
   err = grub_verify_string (xen_state.next_start.cmd_line, 
GRUB_VERIFY_MODULE_CMDLINE);
   ^
In file included from loader/i386/xen.c:43:0:
../include/grub/verify.h:76:1: note: expected 'char *' but argument is of type 
'int8_t *'
grub_verify_string (char *str, enum grub_verify_string_type type);
^
loader/i386/xen.c: In function 'grub_cmd_module':
loader/i386/xen.c:914:10: error: too few arguments to function 
'grub_create_loader_cmdline'
          get_virtual_current_address (ch), cmdline_len);
          ^
In file included from loader/i386/xen.c:38:0:
../include/grub/lib/cmdline.h:29:12: note: declared here
grub_err_t grub_create_loader_cmdline (int argc, char *argv[], char *buf,
            ^
cc1: all warnings being treated as errors
make[3]: *** [loader/i386/linux_module-xen.o] Error 1
make[3]: *** Waiting for unfinished jobs....
mv -f lib/.deps-core/linux_module-cmdline.Tpo 
lib/.deps-core/linux_module-cmdline.Po
mv -f loader/.deps-core/macho_module-lzss.Tpo 
loader/.deps-core/macho_module-lzss.Po
mv -f kern/.deps-core/elf_module-elf.Tpo kern/.deps-core/elf_module-elf.Po
mv -f loader/.deps-core/macho_module-macho.Tpo 
loader/.deps-core/macho_module-macho.Po
mv -f loader/.deps-core/linux_module-linux.Tpo 
loader/.deps-core/linux_module-linux.Po
mv -f gfxmenu/.deps-core/gfxmenu_module-gui_list.Tpo 
gfxmenu/.deps-core/gfxmenu_module-gui_list.Po
mv -f lib/.deps-core/crypto_module-crypto.Tpo 
lib/.deps-core/crypto_module-crypto.Po
mv -f loader/.deps-core/macho_module-macho32.Tpo 
loader/.deps-core/macho_module-macho32.Po
mv -f loader/.deps-core/macho_module-macho64.Tpo 
loader/.deps-core/macho_module-macho64.Po
mv -f normal/.deps-core/normal_module-main.Tpo 
normal/.deps-core/normal_module-main.Po
mv -f normal/.deps-core/normal_module-cmdline.Tpo 
normal/.deps-core/normal_module-cmdline.Po
mv -f io/.deps-core/gzio_module-gzio.Tpo io/.deps-core/gzio_module-gzio.Po
mv -f lib/.deps-core/relocator_module-relocator.Tpo 
lib/.deps-core/relocator_module-relocator.Po
mv -f fs/zfs/.deps-core/zfs_module-zfs.Tpo fs/zfs/.deps-core/zfs_module-zfs.Po
mv -f gnulib/.deps-core/regexp_module-regex.Tpo 
gnulib/.deps-core/regexp_module-regex.Po
make[3]: Leaving directory `/home/fan/grub/grub-core'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/fan/grub/grub-core'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/fan/grub'
make: *** [all] Error 2


Thanks,
Fan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel