[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 01/25] xen/evtchn: expose evtchn_bind_ipi_vcpu0_domain for use within Xen



On Mon, Dec 3, 2018 at 8:20 AM Jan Beulich <JBeulich@xxxxxxxx> wrote:
>
> >>> On 01.12.18 at 02:32, <christopher.w.clark@xxxxxxxxx> wrote:
> > Allocates an IPI-bound event channel on vcpu0 for specified domain.
>
> Please can such changes to general code be done at the point where
> they're needed?
>
> > Is able to bypass the existence check on vcpu number since vcpu 0
> > should always exist. Bypass is required at the point of use by Argo.
>
> "Should" is not a sufficient criteria. And you leave open why such a
> bypass may be needed.
>
> As an aside, I question anyway any new interface special casing
> vCPU 0.

Ack. I'll take a look at how this initialization interacts with
domains with no VCPUs. Agree that the vcpu0 special-case deserves
questioning. Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.