[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] x86: Switch "struct desc_struct" to being seg_desc_t

>>> On 06.12.18 at 19:03, <andrew.cooper3@xxxxxxxxxx> wrote:
> The struct suffix is redundant in the name, and a future change will want to
> turn it into a union, rather than a structure.  As this represents a segment
> descriptor, give it an appropriate typedef.
> No functional change.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

but with a (more general) question: Are we then ourselves on a
position different than some Linux maintainers have taken in the
past, declaring that typedef-s are evil? I've never understood
what reason(s) they had, so please don't take this as an objection
in any way.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.