Re: [Xen-devel] [PATCH] x86/hvm/viridian: stop open coding updates to APIC registers

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.12.18 at 18:50, <paul.durrant@xxxxxxxxxx> wrote:
> The code in viridian_synic_wrmsr() duplicates logic in vlapic_reg_write()
> to update the ICR, ICR2 and TASKPRI registers. Instead of doing this,
> make vlapic_reg_write() non-static and call it.

There's a side effect from this change, which I think should be called
out since perhaps it's actually a (minor) bug fix: vlapic_reg_write()
clears out vlapic->loaded, which the open coded Viridian code didn't
do.

If it wasn't for this, I would have been uncertain whether exposing a
function that really was meant to be vlapic.c-internal is a good idea.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel