[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC 05/16] gic-vgic: Drop an excessive clear_lrs

Hi Andrii,

On 28/11/2018 21:32, Andrii Anisov wrote:
From: Andrii Anisov <andrii_anisov@xxxxxxxx>

This action is excessive because for an invalid LR there is no need
to write another invalid value to a register. So we can skip it here,
saving a peripheral register access.

Signed-off-by: Andrii Anisov <andrii_anisov@xxxxxxxx>
  xen/arch/arm/gic-vgic.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/xen/arch/arm/gic-vgic.c b/xen/arch/arm/gic-vgic.c
index 869987a..4e18169 100644
--- a/xen/arch/arm/gic-vgic.c
+++ b/xen/arch/arm/gic-vgic.c
@@ -227,7 +227,6 @@ static void gic_update_one_lr(struct vcpu *v, int i)
-        gic_hw_ops->clear_lr(i);

I would actually prefer to keep this code for debug build. This makes easier to read the dumped LRs as you don't have to worry about invalid one.

With #ifndef NDEBUG and the appropriate comment:

Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

Feel free to resent it alone so it can be merged to Xen 4.12.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.