Re: [Xen-devel] [RFC 11/16] irq: skip action avalability check for guest's IRQ

[Andrii Anisov <andrii.anisov@xxxxxxxxx>]

On 11.12.18 16:48, Julien Grall wrote:
> And you can't see any potential race in that code happening in the future?
It is protected with `desc->lock` so far. If one decided to get it from under 
the lock, the race is possible with `release_irq()`.

> > Also getting an unknown
> > interrupt is very unlikely on a non-debug platform.
> I am tempted to keep the code at the same place but protect with an #ifndef 
> NDEBUG. What do you think?
Well, I think about a correspondent ASSERT for the guest IRQ. Like following:

> >       if ( test_bit(_IRQ_GUEST, &desc->status) )
> >       {>>           struct irq_guest *info = irq_get_guest_info(desc);
+            ASSERT( desc->action != NULL );

What would you prefer?

--
Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel