[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/2] x86/dom0: rename paging function

>>> On 12.12.18 at 18:05, <roger.pau@xxxxxxxxxx> wrote:
> On Wed, Dec 12, 2018 at 09:15:09AM -0700, Jan Beulich wrote:
>> The MMIO side of things of course still remains unclear.
> Right, for the MMIO and the handling of grant and foreign mappings it's
> not clear how we want to proceed.
> Maybe account for all host RAM (total_pages) plus MMIO BARs?

Well, I thought we've already settled on it being impossible to
account for all MMIO BARs at this point.

>> What I don't understand in any case though is
>> "PAGE_SIZE << PAGE_ORDER_4K". This is x86 code - why not
>> just PAGE_SIZE?
> Oh, I've done it like that because this is related to p2m code, which
> uses this way to get the page size. IIRC you told me to use this for
> things like pvh_setup_e820. I don't mind switching to just PAGE_SIZE.

Oh, I see. It's fine either way then. My general way of thinking
here is that outside of x86 code we better use these
PAGE_ORDER_* values, while in x86 specific code I don't see
the point. But indeed the p2m code is littered with them.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.