[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v1] xen: preserve COMPAT in CFLAGS
Hi, Ian, we have those XC_WANT_COMPAT_* #defines to allow consumers of Xen libs be able to use old interfaces. Do you think it's a good idea to have this consumers (QEMU here) #undef the flag when it has implemented the newer interface? I guess the issue we have here is that when libxc interface are re-implemented into a xen libs, the meaning of XC_WANT_COMPAT_* flags is changed. And the QEMU fails to build even with the flags supplied in cflags. There is another thread that Olaf have started here: <20181025140808.13eefc21.olaf@xxxxxxxxx> https://lists.xenproject.org/archives/html/xen-devel/2018-10/msg01950.html On Fri, Oct 26, 2018 at 12:10:16PM +0200, Olaf Hering wrote: > A given Qemu version can not predict what version of Xen it will run on. > There are some checks in configure to decide what Xen libraries and > functions are available. How exactly these functions must be accessed > has to be decided by configure and the user who is compiling Qemu. > In no way some random header file must override this decision. > > Remove the breakage introduced by commit 5eeb39c24b, which would always > hide the libxc interfaces the given version of Qemu knows about. > > The current symptom of such breakage is a build failure with qemu-2.9 > and older, in combination with Xen 4.12. > > Fixes: 5eeb39c24b7d4da5d129bfdd9c4fd21cfb3d28d6 > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx> > --- > include/hw/xen/xen_common.h | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h > index 5f1402b494..33fa2d3497 100644 > --- a/include/hw/xen/xen_common.h > +++ b/include/hw/xen/xen_common.h > @@ -1,15 +1,6 @@ > #ifndef QEMU_HW_XEN_COMMON_H > #define QEMU_HW_XEN_COMMON_H > > -/* > - * If we have new enough libxenctrl then we do not want/need these compat > - * interfaces, despite what the user supplied cflags might say. They > - * must be undefined before including xenctrl.h > - */ > -#undef XC_WANT_COMPAT_EVTCHN_API > -#undef XC_WANT_COMPAT_GNTTAB_API > -#undef XC_WANT_COMPAT_MAP_FOREIGN_API > - > #include <xenctrl.h> > #include <xenstore.h> > #include <xen/io/xenbus.h> -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |