[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2] x86/vm_event: block interrupt injection for sync vm_events


On 12/13/18 8:03 AM, Razvan Cojocaru wrote:
On 12/13/18 8:54 AM, Tian, Kevin wrote:
From: Razvan Cojocaru [mailto:rcojocaru@xxxxxxxxxxxxxxx]
Sent: Tuesday, December 11, 2018 8:33 PM

In any case, I think you want to rename the function and/or document
more that expected behavior.

You're right, I should probably rename that function / variable to
better reflect what it signifies - that sync vm_event processing is in
progress. For VMX and SVM, that simply means that interrupts will be
blocked, and the value of the variable will be correct and possibly
useful for ARM as well.

what about vm_event_block_interrupt_injection? in that case
it's injection instead of interrupt itself being blocked. blocking
injection should mean same thing cross archs?

Why would you want to block all interrupts injections? When I looked at the details, it feels more you want to block exceptions.

I can see use for blocking exception on Arm, blocking all the interrupts is likely going to bring more issues than solving anything.

So a better name would be vm_event_block_exception_injection.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.