Re: [Xen-devel] [PATCH 24/25] argo: unmap rings on suspend and send signal to ring-owners on resume

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.12.18 at 02:33, <christopher.w.clark@xxxxxxxxx> wrote:
> so that the guest may re-register the rings on resume with current mappings.

Is this something guests really need help with, rather than managing
it on their own? What does "current mappings" here mean, i.e. why
do rings need re-registration in the first place?

> +void
> +argo_resume(struct domain *d)
> +{
> +    bool send_wakeup;
> +
> +    if ( !d )
> +        return;
> +
> +    if ( !get_domain(d) )
> +        return;
> +
> +    read_lock(&argo_lock);
> +
> +    read_lock(&d->argo->lock);
> +    send_wakeup = ( d->argo->ring_count > 0 );
> +    read_unlock(&d->argo->lock);
> +
> +    if ( send_wakeup )
> +        argo_signal_domain(d);
> +
> +    read_unlock(&argo_lock);
> +
> +    put_domain(d);
> +}

domain_resume() also gets called from domain_soft_reset(). Do
you really want such handling in that case as well, when after a
soft-reset the domain is supposed to be "blank"?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel