Re: [Xen-devel] [PATCH v7 2/6] xen/arm: zynqmp: Forward plaform specific firmware calls

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 12/17/18 10:10 PM, Stefano Stabellini wrote:
> diff --git a/xen/arch/arm/platforms/xilinx-zynqmp.c 
> b/xen/arch/arm/platforms/xilinx-zynqmp.c
> index d8ceded..8bc7a9f 100644
> --- a/xen/arch/arm/platforms/xilinx-zynqmp.c
> +++ b/xen/arch/arm/platforms/xilinx-zynqmp.c
> @@ -18,6 +18,8 @@
>    */
>   
>   #include <asm/platform.h>
> +#include <asm/platforms/xilinx-zynqmp-eemi.h>
> +#include <asm/smccc.h>
>   
>   static const char * const zynqmp_dt_compat[] __initconst =
>   {
> @@ -32,8 +34,29 @@ static const struct dt_device_match zynqmp_blacklist_dev[] 
> __initconst =
>       { /* sentinel */ },
>   };
>   
> +static bool zynqmp_smc(struct cpu_user_regs *regs)
> +{
> +    /*
> +     * ZynqMP firmware is based on SMCCC 1.1. If SMCCC 1.1 is not
> +     * available something is wrong, don't try to handle it.
> +     */
> +    if ( !cpus_have_const_cap(ARM_SMCCC_1_1) )
> +    {
> +        static bool once = true;
NIT: Newline here please.

With that:

Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel