[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.12 v3 3/5] xen/arm: p2m: Add support for preemption in p2m_cache_flush_range

Hi Stefano,

On 12/14/18 9:27 PM, Stefano Stabellini wrote:
On Fri, 14 Dec 2018, Julien Grall wrote:
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 17e2523fc1..5639e4b64c 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1524,13 +1524,17 @@ int relinquish_p2m_mapping(struct domain *d)
      return rc;
-int p2m_cache_flush_range(struct domain *d, gfn_t start, gfn_t end)
+int p2m_cache_flush_range(struct domain *d, gfn_t *pstart, gfn_t end)
      struct p2m_domain *p2m = p2m_get_hostp2m(d);
      gfn_t next_block_gfn;
+    gfn_t start = *pstart;
      mfn_t mfn = INVALID_MFN;
      p2m_type_t t;
      unsigned int order;
+    int rc = 0;
+    /* Counter for preemption */
+    unsigned long count = 0;

No need for unsigned long, count could be unsigned int or even unsigned

With this change:

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

I will use unsigned short and commit it.

Thank you for the review!


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.