Re: [Xen-devel] [PATCH v7 4/6] xen/arm: zynqmp: implement zynqmp_eemi

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 18 Dec 2018, Julien Grall wrote:
> Hi Stefano,
> 
> On 12/17/18 10:10 PM, Stefano Stabellini wrote:
> > +    /* These calls are safe and always allowed.  */
> > +    case EEMI_FID(ZYNQMP_SIP_SVC_CALL_COUNT):
> > +    case EEMI_FID(ZYNQMP_SIP_SVC_UID):
> > +    case EEMI_FID(ZYNQMP_SIP_SVC_VERSION):
> 
> I am a bit surprised that you implement those one using SMC64. Why would you
> duplicate the SMC32 version (ARM_SMCCC_CALL_COUNT_FID(SIP))?

This is a mistake introduced in the last couple of versions, good catch.
ZYNQMP_SIP_SVC_* were preexisting, they go back to the initial
implementation by Edgar. The way the code was written before, it didn't
matter if the call was SMC32 or SMC64. Now that we match on the full
FID, and that we have the right SMC32 calls handled, I'll remove these 3
cases completely.


> I also don't seem to find them neither in the spec nor in the ATF code.

Yes, I raised the issue internally. In any case, I think it makes sense
to handle the mandatory calls in Xen by forwarding them to firmware.


> The rest of the code looks good to me.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel