| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
 Re: [Xen-devel] [PATCH v4 3/4] iommu: elide flushing for higher order map/unmap operations
 
To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>From: Julien Grall <julien.grall@xxxxxxx>Date: Wed, 19 Dec 2018 15:38:07 +0000Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "Tim \(Xen.org\)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>, Brian Woods <brian.woods@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>Delivery-date: Wed, 19 Dec 2018 15:38:19 +0000List-id: Xen developer discussion <xen-devel.lists.xenproject.org> 
 
Hi,
On 17/12/2018 09:08, Paul Durrant wrote:
 
@@ -345,7 +352,26 @@ int iommu_legacy_map(struct domain *d, dfn_t dfn,
 
mfn_t mfn,
 
       return rc;
   }
-int iommu_legacy_unmap(struct domain *d, dfn_t dfn, unsigned int
 
page_order)
 
+int iommu_legacy_map(struct domain *d, dfn_t dfn, mfn_t mfn,
+                     unsigned int page_order, unsigned int flags)
+{
+    unsigned int flush_flags = 0;
 
newline here.
 
Ah yes.
 
Actually, hang on... no. Why would I need a newline between two stack variable 
initializations?
 
Yes. Sorry I misread the code.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel 
 |