Re: [Xen-devel] [PATCH v4 3/3] xen/pt: initialize 'warned' field of arch_msix properly

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.12.18 at 16:29, <chao.gao@xxxxxxxxx> wrote:
> --- a/xen/include/asm-x86/msi.h
> +++ b/xen/include/asm-x86/msi.h
> @@ -252,5 +252,10 @@ void guest_mask_msi_irq(struct irq_desc *, bool mask);
>  void ack_nonmaskable_msi_irq(struct irq_desc *);
>  void end_nonmaskable_msi_irq(struct irq_desc *, u8 vector);
>  void set_msi_affinity(struct irq_desc *, const cpumask_t *);
> +static inline void init_arch_msix(struct arch_msix *msix)
> +{
> +    spin_lock_init(&msix->table_lock);
> +    msix->warned = DOMID_INVALID;
> +}

I think this would better sit next to the structure definition,
i.e. a few lines up. In any event a separating blank line
needs adding. With that
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Additionally perhaps arch_init_msix() would better fit our
general naming of arch-specific functions.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel