Re: [Xen-devel] [PATCH V12 2/5] x86/p2m: refactor p2m_reset_altp2m()

[George Dunlap <George.Dunlap@xxxxxxxxxx>]

> On Dec 20, 2018, at 5:38 PM, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx> 
> wrote:
> 
> Refactor p2m_reset_altp2m() so that it can be used to remove
> redundant codepaths, fixing the locking while we're at it.
> 
> The previous code now replaced by p2m_reset_altp2m(d, i,
> ALTP2M_DEACTIVATE) calls did not set p2m->min_remapped_gfn
> and p2m->max_remapped_gfn because in those cases the altp2m
> idx was disabled; so before getting used again,
> p2m_init_altp2m_ept() would get called, which resets them.
> Always setting them in p2m_reset_altp2m(), while redundant,
> is preferable to an extra conditional.
> 
> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> Tested-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel