Re: [Xen-devel] [Qemu-devel] [RFC v2 0/4] QEMU changes to do PVH boot

[no-reply@xxxxxxxxxxx]

Patchew URL: 
https://patchew.org/QEMU/1545422632-24444-1-git-send-email-liam.merwick@xxxxxxxxxx/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 1545422632-24444-1-git-send-email-liam.merwick@xxxxxxxxxx
Type: series
Subject: [Qemu-devel] [RFC v2 0/4] QEMU changes to do PVH boot

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ae98c15 pvh: Boot uncompressed kernel using direct boot ABI
b99fe71 pvh: Add x86/HVM direct boot ABI header file
721dd87 elf-ops.h: Add get_elf_note_type()
4b86551 elf: Add optional function ptr to load_elf() to parse ELF notes

=== OUTPUT BEGIN ===
Checking PATCH 1/4: elf: Add optional function ptr to load_elf() to parse ELF 
notes...
Checking PATCH 2/4: elf-ops.h: Add get_elf_note_type()...
WARNING: Block comments use a leading /* on a separate line
#21: FILE: include/hw/elf_ops.h:268:
+/* Given 'nhdr', a pointer to a range of ELF Notes, search through them

WARNING: Block comments use a leading /* on a separate line
#49: FILE: include/hw/elf_ops.h:296:
+        /* If the offset calculated in this iteration exceeds the

ERROR: code indent should never use tabs
#50: FILE: include/hw/elf_ops.h:297:
+^I * supplied size, we are done and no matching note was found.$

ERROR: code indent should never use tabs
#51: FILE: include/hw/elf_ops.h:298:
+^I */$

ERROR: code indent should never use tabs
#71: FILE: include/hw/elf_ops.h:558:
+^I    /* Search the ELF notes to find one with a type matching the$

WARNING: Block comments use a leading /* on a separate line
#71: FILE: include/hw/elf_ops.h:558:
+           /* Search the ELF notes to find one with a type matching the

ERROR: code indent should never use tabs
#72: FILE: include/hw/elf_ops.h:559:
+^I     * value passed in via 'translate_opaque'$

ERROR: code indent should never use tabs
#73: FILE: include/hw/elf_ops.h:560:
+^I     */$

ERROR: code indent should never use tabs
#75: FILE: include/hw/elf_ops.h:562:
+^I    assert(translate_opaque != NULL);$

total: 6 errors, 3 warnings, 62 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/4: pvh: Add x86/HVM direct boot ABI header file...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

WARNING: architecture specific defines should be avoided
#49: FILE: include/hw/xen/start_info.h:23:
+#ifndef __XEN_PUBLIC_ARCH_X86_HVM_START_INFO_H__

total: 0 errors, 2 warnings, 146 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/4: pvh: Boot uncompressed kernel using direct boot ABI...
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1545422632-24444-1-git-send-email-liam.merwick@xxxxxxxxxx/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@xxxxxxxxxx
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel